refactoring(cli/tui): richlog visualizer#577
Merged
VascoSch92 merged 5 commits intomainfrom Mar 10, 2026
Merged
Conversation
all-hands-bot
approved these changes
Mar 7, 2026
Collaborator
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste
This is textbook refactoring: eliminates 8 instances of copy-pasted logic, ensures consistency, and makes each branch a one-liner. The helper name is clear, and the from_start parameter is used sensibly (file paths show filename, not directory).
Why this is good:
- Solves a real problem (maintenance burden + potential for subtle bugs)
- Simplifies without adding complexity
- No breaking changes (pure refactoring)
Verdict: ✅ Clean, pragmatic solution. Merge it.
Contributor
Coverage Report •
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added _clean_and_truncate() that combines the repeated 3-step sequence:
into one call, replacing 8 inline occurrences in _extract_meaningful_title.
Why: The same 3-line pattern was copy-pasted for every event type branch, making the method 100 lines long and easy to
get subtly wrong (e.g., forgetting to escape or truncate in one branch). The helper makes each branch a one-liner and
ensures consistent processing everywhere.
🚀 Try this PR